In many ways, I feel like the FBI dropping .40 S&W worked wonders for its popularity on the civilian market because the high availability and low prices made them extremely attractive, then once they were actually in peoples hands folks quickly discovered that a lot of the supposed drawbacks of the cartridge such as snappy recoil, slow follow up shots, poor accuracy, and especially the catastrophic failures were grossly exaggerated.
I don’t dislike the 40SW, but I don’t think the FBI dropping it is working wonders for the cartridge. Locally to me sales of new 40SW pistols have fallen off a cliff and if you are trying to sell a used pistol in 40SW some shops don’t even want to bother with it, or require you to slash the price so drastically that you might as well keep it. Private sales just seem to sit.
I think it’s a good time like you said if you’re willing to take a chance on a new cartridge or if you’re already a fan of the cartridge. But what I see in gun stores and at ranges suggests 40SW is become more niche currently. I think it will be interesting to see the popularity of this cartridge over time, and maybe it will have a rebirth like 10mm.