Yes, there are some procedural errors on the officers part. By VA law the officer could and should have asked if the person in question had any weapons in the vehicle or on his person. Once that question had been asked the citizen must divulge if they are in fact armed. This way there would have been no surprise about there being a CHP holder and his concealed handgun.
Now if this question had been asked and then the officer told the CHP holder to step outside the vehicle and to remove his weapon or any other similar order for that matter. What would the citizen then do? By some of the responses so far, it would seem that they would become argumentative and non compliant. Where does this course of action lead? There could be an unsatisfactory conclusion to this situation. Who do you think would be held accountable for such an outcome?
Officers are taught to control a situation, when or if they believe that said situation is not under their control, things can escalate to levels where force might be applied. That level of force will no doubt be in accordance to the level of the perceived threat. A man armed with a handgun, legal or not, can be pretty sure to find that level of force being very high.(read: You will most likely get shot and/or killed.)
The carrying of concealed handguns is deadly serious and should be treated as such. Not everyone is comfortable being around other folks with weapons, legal or otherwise. Knowing this, we should do our best to ease their fears, at least for the duration of our interaction with them. I can agree that the officer shouldn't have said that he would shoot the CHP holder, conversely the CHP holder should know that, since he is armed, there is no longer any wiggle room when dealing with anyone who either knows/believes or is about to know or justifiably believes that they are armed. One armed man getting an attitude with another, who is armed or believed to be armed, isn't very intelligent to say the least. Especially if one of those men is charged with being an agent of the law. The deck is stacked.
If one cannot deal with the serious implications and potential ramifications involved in carrying a firearm, perhaps they shouldn't carry.
Personally this situation appears to be a case of two wrongs and a case of it taking two to tango. Nothing good could come of it and it is good that nothing bad came of it. Both the LEO and CHP holder have some reflecting upon themselves to do. I am glad that nothing bad happened and that this was nothing more than a ruffling of feathers on both parties parts. Live and learn.
Oddly enough, Fairfax doesn't allow open carry, yet here in southern VA we do. It would be nice to have all people on the same page and not have any fears of citizens who carry firearms lawfully. Sadly it probably isn't going to happen in this culture of fear that we seem to be cultivating amongst ourselves. Agreeing to disagree is about as good as it is going to get. Having attitudes and carrying guns isn't a good formula for a happy ending, IMO.