Demand will be the final factor in whether or not they are a good investment or not.
As a rule, I have always stayed away from commemoratives as they are basically white elephants.
In the 80s, I made the mistake of buying not one, but two Colt 1911 John M. Browning 1911 commemorative .45s, thinking that they, for sure, would be THE one hot item among commemoratives. Boy, was I wrong,.
After about 20 years, I finally got my money back out of them. YMMV